Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBox listbox does not resize when last item is made invisible #162

Closed
pixelzoom opened this issue Apr 13, 2020 · 2 comments
Closed

ComboBox listbox does not resize when last item is made invisible #162

pixelzoom opened this issue Apr 13, 2020 · 2 comments
Assignees
@pixelzoom
Labels
dev:phet-io type:bug

Comments

@pixelzoom
Copy link
Contributor

ph-scale and ph-scale basics have a problem with their Solute combobox, recently introduced in common code and described in phetsims/sun#588.

@arouinfar is this a blocking issue for publication?
@pixelzoom pixelzoom changed the title ComboBox listbox does not resize when selected item is made invisible ComboBox listbox does not resize when last item is made invisible Apr 13, 2020
@arouinfar
Copy link
Contributor

@pixelzoom I don't think this is blocking, given that the list box now resizes when the last option is removed. Not sure if you want to keep this open since there is still discussion going on in phetsims/sun#588.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Apr 13, 2020
@pixelzoom
Copy link
Contributor Author

I'm going to close this and trust that it will be handled in phetsims/sun#588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar