Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR process: Maintenance REPL improvements #133

Open
jonathanolson opened this issue May 13, 2019 · 3 comments
Open

MR process: Maintenance REPL improvements #133

jonathanolson opened this issue May 13, 2019 · 3 comments

Comments

@jonathanolson
Copy link
Contributor

As noted in #132, there are essentially two improvements desired:

When using the maintenance REPL in GitBash / Windows 10, TAB auto-complete and Ctrl+C do not work as expected. It would be super nice to get these working for Windows devs.

Can we add history between sessions in the maintenance REPL? It would be convenient to be able to access previously typed commands across sessions.

@jonathanolson
Copy link
Contributor Author

Now --experimental-repl-await may be usable, so it may be possible to get rid of our custom evaluator.

In the documentation (https://nodejs.org/api/repl.html), it seems that using a custom evaluator precludes us from using the option breakEvalOnSigint (which is presumably why the Ctrl+C is exiting). This would require Node 10+, and I'm not sure if it would be compatible with grunt.

Additionally, on Windows (with Git Bash) I can't seem to get any calls to the auto-completion logic.

I'm going to leave unassigned, as I'm getting diminishing returns. @mattpen if you're interested into looking into this, I'd say go for it.

@mattpen
Copy link
Contributor

mattpen commented May 21, 2019

I think @jessegreenberg or @zepumph discovered that the ctrl-c and tab complete work in WSL, so I think if you're seeing diminishing returns that we shouldn't worry about it getting it to work in GitBash.

@jessegreenberg
Copy link
Contributor

In #139 we also discovered that Windows git bash Ctrl+V adds extra \u0016 characters that may be interfering with things.

@zepumph zepumph changed the title Maintenance REPL improvements MR process: Maintenance REPL improvements Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants