From 34bcd56be90e157554623bfc78bb24dcd1ed7b8a Mon Sep 17 00:00:00 2001
From: zepumph <michael.kauzmann@colorado.edu>
Date: Wed, 1 Jun 2022 13:42:54 -0600
Subject: [PATCH] Add ContinuousServerClient.js,
 https://github.com/phetsims/aqua/issues/143

---
 js/common/puppeteerLoad.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/js/common/puppeteerLoad.js b/js/common/puppeteerLoad.js
index 3467fdba..895e3c98 100644
--- a/js/common/puppeteerLoad.js
+++ b/js/common/puppeteerLoad.js
@@ -27,6 +27,7 @@ module.exports = async function( url, options ) {
 
     evaluate: null, // {function|null}
 
+    resolvePageErrors: true, // resolve when the page errors
     waitAfterLoad: 5000, // milliseconds
     allowedTimeToLoad: 40000, // milliseconds
     puppeteerTimeout: 30000 // milliseconds
@@ -49,13 +50,15 @@ module.exports = async function( url, options ) {
     await sleep( options.waitAfterLoad );
     resolve( options.evaluate && !page.isClosed() ? await page.evaluate( options.evaluate ) : null );
   } );
-  page.on( 'error', msg => {
-    winston.info( `puppeteer error: ${msg}` );
-    resolve( new Error( msg ) );
+  page.on( 'error', error => {
+    winston.info( `puppeteer error: ${error}` );
+    resolve( new Error( error ) );
   } );
-  page.on( 'pageerror', msg => {
-    winston.info( `puppeteer pageerror: ${msg}` );
-    resolve( new Error( msg ) );
+  page.on( 'pageerror', error => {
+    winston.info( `puppeteer pageerror: ${error}` );
+    if ( options.resolvePageErrors ) {
+      resolve( new Error( error ) );
+    }
   } );
   ( async () => {
     await sleep( options.allowedTimeToLoad );