-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the word meaning "the" needs to be linked with its noun #86
Comments
This is a translation issue and I don't believe I can address in the code. The pattern string includes The translation for fish looks like the following in babel: And the pattern string in question looks like the following in babel: You can see that the Perhaps this is something that should be communicated to translators, so they know how pattern strings work in those scenarios... it might also be good for developers to keep this in mind so that whenever we have pattern strings with nouns that may move around, the Assigning to @kathy-phet and @jbphet to see if they have any additional thoughts or recommendations here. |
There is a more general GitHub issue that has already been logged for this, please see phetsims/rosetta#314. I think we can and should keep both open, I just wanted to make sure they were linked. The most direct and immediate way to address this would be to give the user more complete control over the string, using either more complex patterns or fully strings. The tradeoff is that it will likely be a bit more challenging for translators to understand, and also more likely that mistakes will be made. By the way, this is exactly why we can't apply Rosetta to the translation of accessibility strings. As strings get longer we begin to encounter a lot of grammar and punctuation challenges. I'm happy to work on this if we collectively decide it's a priority. I don't think it would take too long to work out, but I'd have to go back through and fix up all the existing translations and either do a maintenance release or a re-release off of main (maybe this could be coupled with the release for new characters?), so it's not trivial. It would probably take a couple of focused days. |
Unassigning myself until this gets prioritized. |
Let's continue to defer this issue. It's a great catch! And a point that we should keep in mind for sims, but we can't afford the effort to fix it at the moment. |
Test device
MacBook Air M1 chip
Operating System
14.1.2
Browser
Safari 17.1.2
Problem description
For phetsims/qa#1009, in some locales other than English there are several forms of the word "the". After switching which item is assigned to each variable, those items switch places in the Distance Statement but the word meaning "the" doesn't, leading to incorrect translations.
I noticed this in the third scene of the Explore Screen with Italian and French (but I'm sure there are others).
Steps to reproduce
This also happens with "directed distance" selected.
Visuals
In Italian:
wordsDontSwitch.mp4
In French:
The text was updated successfully, but these errors were encountered: