Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This sim does not have a color profile. #48

Closed
pixelzoom opened this issue Jul 19, 2021 · 2 comments
Closed

This sim does not have a color profile. #48

pixelzoom opened this issue Jul 19, 2021 · 2 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

For code review #35:

All sims should have a ColorProfile, named {{PREFIX}}ColorProfile.js, even if they have a single (default)
profile. See phetsims/scenery-phet#642.

While phetsims/scenery-phet#642 is the general issue, I'm creating this sim-specific issue, so that the team can decide whether to create a color profile this late in the game.

Note that there will no longer be a ColorProfile class, and sims should use the new pattern that @samreid has established in phetsims/scenery-phet#642.

@pixelzoom
Copy link
Contributor Author

@SaurabhTotey
Copy link
Member

Since there is now a color profile, I will close this issue.

@SaurabhTotey SaurabhTotey removed their assignment Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants