Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Test for phet brand #36

Closed
SaurabhTotey opened this issue Jul 6, 2021 · 2 comments
Closed

Memory Test for phet brand #36

SaurabhTotey opened this issue Jul 6, 2021 · 2 comments

Comments

@SaurabhTotey
Copy link
Member

Standard code review issue. Created for #35. I'll perform the memory test and put the data here soon.

@SaurabhTotey SaurabhTotey mentioned this issue Jul 6, 2021
@SaurabhTotey
Copy link
Member Author

First run: Tested using the built_all_debug version from master, SHA was 3a7c86f, common code was whatever was on master today, 07/13/2021.

Test Memory Usage (MB)
Immediately after load, no fuzzing 22.1
Load, visit each screen, then back to home screen, no fuzzing 22.6
After 1 min of fuzz 27.8
After 2 min of fuzz 28.6
After 3 min of fuzz 28.6
After 4 min of fuzz 28.9
After 5 min of fuzz 29.2
Stop fuzz, reset each screen, go to home screen 29.3

This seems like it is a reasonable memory growth profile. With @jbphet, we compared the post-fuzz and pre-fuzz snapshots and saw no leakage of sim-specific classes. I will leave this issue open, and let @pixelzoom close at their discretion when doing the code review.

@SaurabhTotey SaurabhTotey mentioned this issue Jul 18, 2021
@pixelzoom
Copy link
Contributor

I agree, looks reasonable. QA will verify again during dev/RC testing, as part of their standard procedures, so I won't spend time re-running tests. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants