Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff wrapper getPhetioAPI assumes a relative path for API file #274

Closed
pixelzoom opened this issue Apr 24, 2021 · 1 comment
Closed

Diff wrapper getPhetioAPI assumes a relative path for API file #274

pixelzoom opened this issue Apr 24, 2021 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 24, 2021

This issue is to track https://github.com/phetsims/phet-io-wrappers/issues/405 for Natural Selection 1.3.

In https://github.com/phetsims/phet-io-wrappers/issues/405#issuecomment-826008418, @zepumph described that issue as blocking:

I also saw that this is a actually completely different problem from what was originally reported in #271, and the "APIs are identical" output was actually because of a bug where the "other sim URL" was loading the SAME (this sim's) API file instead of going out and grabbing the other sim's api. I created #406 to solve that, which is also blocking. To fix that, we need this issue to be working though, so both bugs are important improvements, and both blocking NS release.

In 4/23/21 Slack, @zepumph didn't say whether that issue is blocking:

Updates about blocking issues:
...

@zepumph @kathy-phet please clarify: Is this blocking for NS 1.3 ?

@pixelzoom pixelzoom changed the title diff wrapper getPhetioAPI assumes a relative path for api file Diff wrapper getPhetioAPI assumes a relative path for api file Apr 24, 2021
@pixelzoom pixelzoom changed the title Diff wrapper getPhetioAPI assumes a relative path for api file Diff wrapper getPhetioAPI assumes a relative path for API file Apr 24, 2021
@pixelzoom pixelzoom added the type:bug Something isn't working label Apr 26, 2021
@pixelzoom
Copy link
Contributor Author

Closing, this can be tracked in #271. See #271 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants