Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use IOType.fromCoreType to create IO Types #255

Closed
5 of 6 tasks
pixelzoom opened this issue Nov 10, 2020 · 2 comments
Closed
5 of 6 tasks

use IOType.fromCoreType to create IO Types #255

pixelzoom opened this issue Nov 10, 2020 · 2 comments
Assignees
@pixelzoom
Labels
dev:phet-io status:blocks-sim-publication

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 10, 2020 •
edited
Loading

phetsims/tandem#213 introduces IOType.fromCoreType, a new factory method for creating IO Types. In 6c49ba5, @zepumph changed Wolf.js to use IOType.fromCoreType. When that issue is resolved, we should probably change other IO Types, including:

  • Bunny
  • BunnyCounts
  • GenePair
  • Genotype
  • Phenotype
  • ProportionsCounts
@pixelzoom pixelzoom self-assigned this Nov 10, 2020
@pixelzoom pixelzoom mentioned this issue Nov 10, 2020
Closed
@pixelzoom
Copy link
Contributor Author

Looks like @zepumph changed these in f944f3e. Reviewing...

pixelzoom referenced this issue Nov 13, 2020
@zepumph
use IOType.fromCoreType in Natural Selection, phetsims/tandem#213
f944f3e
@pixelzoom
Copy link
Contributor Author

Looks good and I don't see any problems in local testing. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom