-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider design of Spectrometer snapshots #34
Comments
7/14/2022 design meeting: The general feeling was:
|
Unassigning myself until work resumes on this sim. |
In today's design meeting:
|
Related to #1 design refresh...
The HTML5 design doc adds what looks like radio buttons to the top of each snapshot in the Spectrometer:
These are not in fact radio buttons. They are showing you (left to right) which model was involved for the complete set of snapshots. And the highlighted one is the model that corresponds to that snapshot. This is potentially confusing because they look like radio buttons. And I'm not sure why it's even necessry, since the name of the model appears in the upper-left of the snapsot (where we could add the icon too, if we really think the icon is needed).
Furthermore, the design doc says:
Then says:
So I don't understand why there are 5 icons shown in each snapshot. Or how all 5 icons can be filled in, as shown in some of the mockups. If there are at most 3 snapshots, won't 2 of the icons always be blank?
Finally, this row of icons (appearing in every snapshot) takes of precious vertical realestate. I'd much rather allocate that realestate to the columns of dots in the spectometer's graph.
Assigning to @arouinfar to clarify/reconsider this design. My feeling is that we should lose these icons, and do something closer to the Java version.
The text was updated successfully, but these errors were encountered: