Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider design of Spectrometer snapshots #34

Open
pixelzoom opened this issue Jul 5, 2022 · 3 comments
Open

Reconsider design of Spectrometer snapshots #34

pixelzoom opened this issue Jul 5, 2022 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 5, 2022

Related to #1 design refresh...

The HTML5 design doc adds what looks like radio buttons to the top of each snapshot in the Spectrometer:

screenshot_1751

These are not in fact radio buttons. They are showing you (left to right) which model was involved for the complete set of snapshots. And the highlighted one is the model that corresponds to that snapshot. This is potentially confusing because they look like radio buttons. And I'm not sure why it's even necessry, since the name of the model appears in the upper-left of the snapsot (where we could add the icon too, if we really think the icon is needed).

Furthermore, the design doc says:

The dialog box contains up to three snapshots of spectrometers

Then says:

screenshot_1752

So I don't understand why there are 5 icons shown in each snapshot. Or how all 5 icons can be filled in, as shown in some of the mockups. If there are at most 3 snapshots, won't 2 of the icons always be blank?

Finally, this row of icons (appearing in every snapshot) takes of precious vertical realestate. I'd much rather allocate that realestate to the columns of dots in the spectometer's graph.

Assigning to @arouinfar to clarify/reconsider this design. My feeling is that we should lose these icons, and do something closer to the Java version.

@pixelzoom pixelzoom changed the title Reconside design of Spectrometer snapshots Reconsider design of Spectrometer snapshots Jul 5, 2022
@pixelzoom pixelzoom mentioned this issue Jul 5, 2022
@pixelzoom
Copy link
Contributor Author

7/14/2022 design meeting:

The general feeling was:

  • drop the things that look like radio buttons
  • add an icon next to the model name
  • number the snapshots

@arouinfar
Copy link

Unassigning myself until work resumes on this sim.

@DianaTavares
Copy link
Contributor

In today's design meeting:

image

  • Display 3-4 snapshots in the dialog (maximum possible while being readable).

  • Name snapshots ‘Model Name #’, where the number is incremented as more screenshots are taken.

  • Move the trash button to the upper right corner of the snapshot so it doesn’t cover data.

  • Delete the record button from Spectrometer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants