Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not always able to predict mean on the Distribute screen #296

Closed
jessegreenberg opened this issue Jun 14, 2024 · 3 comments
Closed

Not always able to predict mean on the Distribute screen #296

jessegreenberg opened this issue Jun 14, 2024 · 3 comments

Comments

@jessegreenberg
Copy link
Contributor

This is a behavior question, I am not sure if it is a bug. To observe:

  1. Got to distribute screen
  2. Enable "Predict Mean"
  3. Drag the pencil up and down.

There is no position where the mean displays a success. If this is the expected behavior, feel free to close.

For #270.

@jessegreenberg
Copy link
Contributor Author

The code indicates that you should only be able to observe successes if the snacks are distributed, so maybe this is an intentional part of the model:

const successStrokeColorWasSet = predictMeanLine.stroke === MeanShareAndBalanceColors.meanColorProperty;
if ( snacksDistributed ) {
const meanTolerance = 0.5;
const roundedPrediction = Utils.roundToInterval( meanPrediction, 0.1 );
const roundedMean = Utils.roundToInterval( meanValue, 0.1 );

@marlitas
Copy link
Contributor

Yes, this is the expected behavior. I'll go ahead and assign to @amanda-phet since it was a question about behavior. Not sure if necessary to do anything about it, but want to make sure she is aware that it came up. Feel free to close if you want to leave as is.

@amanda-phet
Copy link
Contributor

Yes this is intentional. If you place the line you are just making a prediction. This seemed clear in interviews so I think it's fine to keep as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants