You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a "code polishing" issue, mainly for my benefit.
I'd like to find a better (or at least more uniform) way of specifying the locations of particles for screen icons. For example, in GasPropertiesIconFactory createDiffusionScreenIcon, I currently have:
// Particles, locations determined empirically, relative to centerX of divider, specified left to rightconstparticle1Locations=[newVector2(-400,300),newVector2(-600,600),newVector2(-340,800)];constparticle2Locations=[newVector2(400,300),newVector2(660,740)];
While this is in code that is unlikely to change and isn't related to anything else, it still feels a little fragile, and there was some trial-&-error ("empirically") required to arrive at the values.
The text was updated successfully, but these errors were encountered:
Think I'm going to leave this one "as is". The documentation is clear, and I don't think there's an obviously superior way to do this that doesn't involve a lot of work. So closing, and we'll see if it comes up in code review.
This is a "code polishing" issue, mainly for my benefit.
I'd like to find a better (or at least more uniform) way of specifying the locations of particles for screen icons. For example, in GasPropertiesIconFactory
createDiffusionScreenIcon
, I currently have:While this is in code that is unlikely to change and isn't related to anything else, it still feels a little fragile, and there was some trial-&-error ("empirically") required to arrive at the values.
The text was updated successfully, but these errors were encountered: