From c3931c7994cd51eded2e962a77dcfa1d0a3fd991 Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Mon, 20 Sep 2021 16:44:08 -0600 Subject: [PATCH] document why NumberControl title is '', https://github.com/phetsims/fourier-making-waves/issues/165 --- js/wavepacket/view/WavePacketNumberControl.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/wavepacket/view/WavePacketNumberControl.js b/js/wavepacket/view/WavePacketNumberControl.js index f40f502c..7cb1bc39 100644 --- a/js/wavepacket/view/WavePacketNumberControl.js +++ b/js/wavepacket/view/WavePacketNumberControl.js @@ -35,8 +35,8 @@ class WavePacketNumberControl extends NumberControl { tandem: Tandem.REQUIRED }, FMWConstants.WAVE_PACKET_NUMBER_CONTROL_OPTIONS, options ); - //REVIEW: Looks like the layoutFunction doesn't use the title, is that why the empty-string is passed here? - super( '' /* title */, numberProperty, numberProperty.range, options ); + // The layoutFunction doesn't use the title, so provide empty string. + super( '', numberProperty, numberProperty.range, options ); // Make tick label interactive, so that pressing on a tick label sets the Property to that value. if ( options.sliderOptions && options.sliderOptions.majorTicks ) {