Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing water in pool #421

Closed
KatieWoe opened this issue Oct 7, 2024 · 4 comments
Closed

Losing water in pool #421

KatieWoe opened this issue Oct 7, 2024 · 4 comments
Assignees
Labels

Comments

@KatieWoe
Copy link

KatieWoe commented Oct 7, 2024

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#1149.
While running a fuzz test on Buoyancy, I noticed that the liquid volume of the pool would go under 98.2 L. It looked like it was on the last screen, though the fuzz test went fast enough it was hard to tell. I didn't see any console errors and haven't figured out how to do this without fuzzing.

Visuals
lowerwater

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Buoyancy‬
URL: https://phet-dev.colorado.edu/html/buoyancy/1.2.0-rc.2/phet/buoyancy_all_phet.html
Version: 1.2.0-rc.2 2024-10-04 21:51:42 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36
Language: en-US
Window: 1280x631
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:bug Something isn't working label Oct 7, 2024
@zepumph
Copy link
Member

zepumph commented Oct 7, 2024

Do you still have the tab open? You can type this to stop the fuzzing:

phet.chipper.queryParameters.fuzz =false

Then you can see specifically if the pool has lost water. I'm also curious if that is indeed a problem, if resetting all brings back the water.

@KatieWoe
Copy link
Author

KatieWoe commented Oct 7, 2024

I can reproduce it after a few minutes of fuzzing. I'll see what I can find.

@KatieWoe
Copy link
Author

KatieWoe commented Oct 7, 2024

I might have found it. If the boat floods, then when bringing it up the pool volume drops quite a bit, which seems normal. It's hard to tell if that's what I'm seeing while fuzzing, but it's my best guess at this point. May be a false alarm.
maybe

@zepumph
Copy link
Member

zepumph commented Oct 7, 2024

Ok sounds good. That makes sense to me, and I also see code that resets the pool to the right value on reset all so likely it isn't a case where the pool can get very very off while fuzzing since resetting occurs so often.

Feel free to close and let me know if you want to discuss anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants