Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool Scale is in the wrong place in focus order #191

Closed
Nancy-Salpepi opened this issue Jun 12, 2024 · 3 comments
Closed

Pool Scale is in the wrong place in focus order #191

Nancy-Salpepi opened this issue Jun 12, 2024 · 3 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jun 12, 2024

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Safari 17.5

Problem description
For phetsims/qa#1095:
On all screens the Pool Scale control is after the Reset All button in the focus order. According to https://docs.google.com/document/d/1p-GwOR0jEsaJEouib6drVwLAti2J21-v1uVSpkoeZ5c/edit#heading=h.nhqxjbby3dgu from #121 the pool scale should come after the other scale on the Compare, Explore and Shapes Screens. On the Lab Screen, it should be after the Block and on the Applications Screen after the Fluid Density control.

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Buoyancy‬ URL: https://phet-dev.colorado.edu/html/buoyancy/1.0.0-dev.9/phet/buoyancy_all_phet.html Version: 1.0.0-dev.9 2024-06-12 15:13:18 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15 Language: en-US Window: 1380x706 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@AgustinVallejo
Copy link
Contributor

Assigning myself to work on this

@AgustinVallejo
Copy link
Contributor

Addressed in the above commit. Please review and close if ready @Nancy-Salpepi. Thanks!

@Nancy-Salpepi
Copy link
Author

Looks good!
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants