Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output-js-project broken on 1.3.0 #166

Open
zepumph opened this issue Oct 18, 2024 · 2 comments
Open

output-js-project broken on 1.3.0 #166

zepumph opened this issue Oct 18, 2024 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Oct 18, 2024

I just found a bug on main that snuck into the most recent release of color vision. Transpiling will be project for any maintenance releases that it will get.

If you see here: https://github.com/phetsims/chipper/blob/0dbc5d719a7cb5c94ffc7f4f3c0f27fe74fc984c/js/grunt/tasks/output-js-project.ts

There was a copy paste error, and output-js-project should be transpiling all phet libs, but is only doing the single repo.

I'll make an RC with the change patched in, and we can go from there.

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2024

Discovered while working on phetsims/chipper#1499.

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant