Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: should have type: SingleBulbPhotonIO in allTypes #132

Open
pixelzoom opened this issue Feb 18, 2020 · 2 comments
Open

CT: should have type: SingleBulbPhotonIO in allTypes #132

pixelzoom opened this issue Feb 18, 2020 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

Similar to phetsims/beers-law-lab#244. This longstanding problem was apparently revealed when Studio started running on CT again recently. The solution is to port dynamic SingleBulbPhoton to use PhetioGroup.

color-vision : phet-io-studio-fuzz : require.js : run
Uncaught Error: should have type: SingleBulbPhotonIO in allTypes. May need grunt update?
Error: should have type: SingleBulbPhotonIO in allTypes. May need grunt update?
    at window.assert (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/assert.js:32:13)
    at getCreator (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/StudioInstanceCreator.js:778:15)
    at StudioInstanceCreator.createStudioInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/StudioInstanceCreator.js:61:26)
    at Studio.onPhetioElementAdded (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/Studio.js:276:63)
    at phetioElementAdded (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/main.js:50:26)
    at Client.dispatch (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/Client.js:452:56)
    at windowMessageListener (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/Client.js:341:24)
id: Bayes Chrome
Approximately 2/18/2020, 6:24:08 AM
@pixelzoom
Copy link
Contributor Author

Before working on this issue, verify that individual photons really need to be instrumented. Don't make the same mistake that was apparently made in phetsims/beers-law-lab#244 (comment).

@Luisav1
Copy link
Contributor

Luisav1 commented Apr 29, 2024

Deferring this issue since we're not going to republish with PhET-iO for the upcoming publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants