Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze on IE when focusing on an item #485

Closed
KatieWoe opened this issue Apr 26, 2019 · 7 comments
Closed

Freeze on IE when focusing on an item #485

KatieWoe opened this issue Apr 26, 2019 · 7 comments

Comments

@KatieWoe
Copy link
Contributor

Test device:
Dell
Operating System:
Win 10
Browser:
IE
Problem description:
For phetsims/qa#311. When focusing on a circuit item to change it's resistance or voltage, the sim freezes and must be refreshed. Does not occur for items like the wire where a trash button is the only thing available. So far only seen on IE, but it makes the sim unusable.
Steps to reproduce:

  1. Grab a battery, resistor, or fuse
  2. Click on the item so that a slider that would control some property would come up
  3. The sim will now no longer respond to any clicking and must be refreshed.

Screenshots:
focusfreeze

Troubleshooting information (do not edit):

Name: ‪Circuit Construction Kit: DC‬
URL: https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-dev.3/phet/circuit-construction-kit-dc_en_phet.html
Version: 1.1.0-dev.3 2019-04-25 18:12:14 UTC
Features missing: touch, fullscreen
Flags: pointerEnabled, msPointerEnabled, pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; Touch; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Tablet PC 2.0; Zoom 3.6.0; rv:11.0) like Gecko
Language: en-US
Window: 1536x750
Pixel Ratio: 2.5/1
WebGL: WebGL 0.94
GLSL: WebGL GLSL ES 0.94
Vendor: Microsoft (Internet Explorer)
Vertex: attribs: 16 varying: 15 uniform: 512
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@samreid
Copy link
Member

samreid commented Apr 26, 2019

Is this problem also in the published version?

@KatieWoe
Copy link
Contributor Author

No it is not.

@samreid
Copy link
Member

samreid commented Apr 29, 2019

Is an error message reported in the console?

@KatieWoe
Copy link
Contributor Author

console

@samreid
Copy link
Member

samreid commented Apr 29, 2019

I pushed a proposed fix to address phetsims/scenery-phet#493, however, it cannot be tested with assertions enabled because some assertions in our codebase use Array.prototype.includes. So I've published a dev version for testing this: https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-dev.4/phet/circuit-construction-kit-dc_en_phet.html

@KatieWoe can you please check if it is OK now?

@samreid samreid removed their assignment Apr 29, 2019
@KatieWoe
Copy link
Contributor Author

Problem seems to be solved there @samreid

@samreid
Copy link
Member

samreid commented Apr 29, 2019

Thanks, I'll close this issue.

@samreid samreid closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants