Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale info is still a "ROUGH DRAFT". Make it production ready. #1375

Closed
pixelzoom opened this issue Feb 1, 2023 · 1 comment
Closed

Locale info is still a "ROUGH DRAFT". Make it production ready. #1375

pixelzoom opened this issue Feb 1, 2023 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 1, 2023

While working on #1374, I was examining commits for localeInfoModule.js, the primary source for PhET locale information that is displayed in Preferences and elsewhere.

There is a single comment by @jonathanolson about this file in #1302 (comment):

Added a VERY rough-draft locale switcher in the navbar for demo-ing, see https://bayes.colorado.edu/dev/olsonjb/locale-test.html

This is a single commit by @jonathanolson in GitHub for this file, with this message:

Adding ROUGH DRAFT locale switcher for development purposes, see #1302

In both cases the use of cap ("VERY rough-draft" and "ROUGH DRAFT") seems significant. And there's even an acknowledge that this isn't ready for production ("for development purposes") - which I can vouch for given issues like #1374.

So given that a huge amount of work has been done since August to support dynamic locale, and that this is the foundation that's now "included in all sims"... Do you think we should move this from the "ROUGH DRAFT" stage to production-ready?

@jonathanolson for comment. @kathy-phet for prioritization.

@jonathanolson
Copy link
Contributor

The "rough draft" parts referred to the temporary locale switcher, which has been phased out and removed. Is there something that should be done about locale info? I'm not aware of any "rough" bits right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants