Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTQ formatting problem for "error testing phetioCompare" #210

Open
pixelzoom opened this issue May 10, 2024 · 3 comments
Open

CTQ formatting problem for "error testing phetioCompare" #210

pixelzoom opened this issue May 10, 2024 · 3 comments
Labels

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 10, 2024

For phetsims/chipper#1350, @zepumph made a number of commits to "compare all stable sims for CTQ". Those commits are linked just below phetsims/chipper#1350 (comment).

It looks like there's a markdown problem with how these CTQ notifications appears in Slack. For example:

screenshot_3289




Other CTQ notifications are formatted like this:

screenshot_3290
@zepumph
Copy link
Member

zepumph commented May 13, 2024

The formatting looks right, but it seems to have come in two different messages for some reason:

First message:

CTQ failing:
-three backtics-
error testing phetioCompare: buoyancy-basics BREAKING PROBLEMS
buoyancyBasics.compareScreen.model.blockSets.sameDensity.blockA.materialProperty._data.initialState differs.
Expected:
{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":400,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":71,"g":75,"r":235},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":400,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":235,"g":75,"b":71,"a":1},"customColor":null,"staticLiquidColor":{"r":235,"g":75,"b":71,"a":1},"liquidColor":null},"validValues":null,"units":null}
buoyancyBasics.compareScreen.model.blockSets.sameDensity.blockB.materialProperty._data.initialState differs.
Expected:
{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":400,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":175,"g":105,"r":67},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":400,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":67,"g":105,"b":175,"a":1},"customColor":null,"staticLiquidColor":{"r":67,"g":105,"b":175,"a":1},"liquidColor":null},"validValues":null,"units":null}
buoyancyBasics.compareScreen.model.blockSets.sameMass.blockA.materialProperty._data.initialState differs.
Expected:
{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":500,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":47,"g":52,"r":219},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":500,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":219,"g":52,"b":47,"a":1},"customColor":null,"staticLiquidColor":{"r":219,"g":52,"b":47,"a":1},"liquidColor":null},"validValues":null,"units":null}
buoyancyBasics.compareScreen.model.blockSets.sameMass.blockB.materialProperty._data.initialState differs.
Expected:
{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":2500,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":73,"g":39,"r":21},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":2500,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":21,"g":39,"b":73,"a":1},"customColor":null,"staticLiquidColor":{"r":21,"g":39,"b":73,"a":1},"liquidColor":null},"validValues":null,"units":null}
buoyancyBasics.compareScreen.model.blockSets.sameVolume.blockA.materialProperty._data.initialState differs.
Expected:

Then another message

{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":400,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":71,"g":75,"r":235},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":400,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":235,"g":75,"b":71,"a":1},"customColor":null,"staticLiquidColor":{"r":235,"g":75,"b":71,"a":1},"liquidColor":null},"validValues":null,"units":null}
buoyancyBasics.compareScreen.model.blockSets.sameVolume.blockB.materialProperty._data.initialState differs.
Expected:
{"units":null,"validValues":null,"value":{"custom":true,"customColor":null,"density":2000,"hidden":false,"identifier":null,"liquidColor":null,"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"staticCustomColor":{"a":1,"b":82,"g":44,"r":23},"staticLiquidColor":null,"tandemName":"custom","viscosity":0.001}}
actual:
{"value":{"name":{"phetioID":"buoyancyBasics.general.model.strings.densityBuoyancyCommon.material.customStringProperty"},"identifier":null,"tandemName":"custom","density":2000,"viscosity":0.001,"custom":true,"hidden":false,"staticCustomColor":{"r":23,"g":44,"b":82,"a":1},"customColor":null,"staticLiquidColor":{"r":23,"g":44,"b":82,"a":1},"liquidColor":null},"validValues":null,"units":null}
-three backtics-

@zepumph zepumph removed their assignment May 14, 2024
@pixelzoom
Copy link
Contributor Author

This is still a problem as of 6/17/2024:

screenshot_3366

@zepumph
Copy link
Member

zepumph commented Sep 26, 2024

I just saw an error on the server that says:

|ct-quick | 2024-09-26T11:48:56: [WARN]  bolt-app message_truncated 0 [ 'message_truncated' ]
1|ct-quick | 2024-09-26T11:48:56: [WARN]  bolt-app Your message was truncated but still posted. The `text` field accepts up to 40,000 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants