Make all cpu methods work on cpu pointer. This improved performance as no copies of cpu were done anymore.

pherrymason · pherrymason · commit 69d684ee67a1 · 2022-08-08T12:32:09.000+02:00
diff --git a/src/nes/cpu6502.go b/src/nes/cpu6502.go
@@ -37,7 +37,7 @@ func CreateCPU(memory Memory, debugger *cpu.Debugger) *Cpu6502 {
 	return &cpu6502
 }
 
-func (cpu6502 Cpu6502) ProgramCounter() types.Address {
+func (cpu6502 *Cpu6502) ProgramCounter() types.Address {
 	return cpu6502.Registers().Pc
 }
 
@@ -394,7 +394,7 @@ func (cpu6502 *Cpu6502) initAddressModeEvaluators() {
 	}
 }
 
-func (cpu6502 Cpu6502) evaluateOperandAddress(addressMode cpu.AddressMode, pc types.Address) (finalAddress types.Address, operand [3]byte, pageCrossed bool) {
+func (cpu6502 *Cpu6502) evaluateOperandAddress(addressMode cpu.AddressMode, pc types.Address) (finalAddress types.Address, operand [3]byte, pageCrossed bool) {
 	if addressMode == cpu.Implicit {
 		finalAddress = 0
 		return

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ func CreateCPU(memory Memory, debugger cpu.Debugger) Cpu6502 {`
`37`	`37`	`return &cpu6502`
`38`	`38`	`}`
`39`	`39`
`40`		`-func (cpu6502 Cpu6502) ProgramCounter() types.Address {`
	`40`	`+func (cpu6502 *Cpu6502) ProgramCounter() types.Address {`
`41`	`41`	`return cpu6502.Registers().Pc`
`42`	`42`	`}`
`43`	`43`
`@@ -394,7 +394,7 @@ func (cpu6502 *Cpu6502) initAddressModeEvaluators() {`
`394`	`394`	`}`
`395`	`395`	`}`
`396`	`396`
`397`		`-func (cpu6502 Cpu6502) evaluateOperandAddress(addressMode cpu.AddressMode, pc types.Address) (finalAddress types.Address, operand [3]byte, pageCrossed bool) {`
	`397`	`+func (cpu6502 *Cpu6502) evaluateOperandAddress(addressMode cpu.AddressMode, pc types.Address) (finalAddress types.Address, operand [3]byte, pageCrossed bool) {`
`398`	`398`	`if addressMode == cpu.Implicit {`
`399`	`399`	`finalAddress = 0`
`400`	`400`	`return`