Skip to content

add missing 'f' to error message f-strings#1161

Merged
phenobarbital merged 1 commit into
phenobarbital:masterfrom
roymanigley:fix-error-message-f-strings
Jul 8, 2024
Merged

add missing 'f' to error message f-strings#1161
phenobarbital merged 1 commit into
phenobarbital:masterfrom
roymanigley:fix-error-message-f-strings

Conversation

@roymanigley
Copy link
Copy Markdown
Contributor

@roymanigley roymanigley commented Jul 6, 2024

Closes #1160

Summary by Sourcery

This pull request fixes the formatting of error messages in the SQLite driver by adding missing 'f' prefixes to f-strings, ensuring that error details are correctly included in the messages.

  • Bug Fixes:
    • Fixed missing 'f' in error message f-strings to ensure proper error message formatting in asyncdb/drivers/sqlite.py.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jul 6, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @roymanigley - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment thread asyncdb/drivers/sqlite.py
Comment thread asyncdb/drivers/sqlite.py
Comment thread asyncdb/drivers/sqlite.py
@roymanigley
Copy link
Copy Markdown
Contributor Author

@sourcery-ai review

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed the commit b9b17a0 in this pull request.

@phenobarbital phenobarbital merged commit 66ce03c into phenobarbital:master Jul 8, 2024
phenobarbital added a commit that referenced this pull request Mar 20, 2026
add missing 'f' to error message f-strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing 'f' on error message f-strings

2 participants