No text in unsupportedOperationException; see #96

Author: phax

src/main/java/com/helger/jcodemodel/JCodeModel.java

@@ -274,7 +274,7 @@ public static JCodeModel createUnified ()
     catch (final JCodeModelException e)
     {
       // should not happen
-      throw new UnsupportedOperationException ("This is the famous 'should never occur' error", e);
+      throw new UnsupportedOperationException (e);
     }
   }
 
@@ -1085,7 +1085,7 @@ public static JCodeModel copySerial (final JCodeModel source)
     }
     catch (final IOException | ClassNotFoundException e)
     {
-      throw new UnsupportedOperationException ("Failed to write code model to string", e);
+      throw new UnsupportedOperationException (e);
     }
   }
 

src/main/java/com/helger/jcodemodel/JResourceDir.java

@@ -105,8 +105,8 @@ public class JResourceDir implements IJOwned, Serializable
    *         If a part of the package name is not a valid filename part.
    */
   protected JResourceDir (@Nonnull final JCodeModel aOwner,
-      @Nullable final JResourceDir aParentDir,
-      @Nonnull final String sName) throws JInvalidFileNameException
+                          @Nullable final JResourceDir aParentDir,
+                          @Nonnull final String sName) throws JInvalidFileNameException
   {
     ValueEnforcer.notNull (sName, "Name");
     ValueEnforcer.notNull (aOwner, "CodeModel");
@@ -324,7 +324,7 @@ static JResourceDir root (@Nonnull final JCodeModel aOwner)
     catch (final JInvalidFileNameException e)
     {
       // should not happen
-      throw new UnsupportedOperationException ("catch this", e);
+      throw new UnsupportedOperationException (e);
     }
   }
 }

src/main/java/com/helger/jcodemodel/compile/ClassLoaderFileManager.java

@@ -221,7 +221,7 @@ public JavaFileObject getJavaFileForOutput (final Location location,
       }
       catch (final Exception e)
       {
-        throw new UnsupportedOperationException ("while creating code for " + className, e);
+        throw new UnsupportedOperationException (e);
       }
     return ret;
   }

src/main/java/com/helger/jcodemodel/compile/DynamicClassLoader.java

@@ -57,10 +57,9 @@
 /**
  * class loader that allows dynamic classes and resources.
  * <p>
- * add class models using {@link #setCode(CompiledCodeJavaFile)} , add resources
- * using {@link #addResources(Map)}; then you can use it as a normal
- * classloader, eg {@link ClassLoader#loadClass(String)} or
- * {@link ClassLoader#getResource(String)}
+ * add class models using {@link #setCode(CompiledCodeJavaFile)} , add resources using
+ * {@link #addResources(Map)}; then you can use it as a normal classloader, eg
+ * {@link ClassLoader#loadClass(String)} or {@link ClassLoader#getResource(String)}
  * </p>
  */
 public class DynamicClassLoader extends ClassLoader
@@ -69,9 +68,9 @@ public class DynamicClassLoader extends ClassLoader
   private final Map <String, NonBlockingByteArrayOutputStream> m_aCustomResources = new HashMap <> ();
 
   /**
-   * internal url handler that generates url to load inside its own resources,
-   * if exists. It overloads the openConnection to provide an input stream if a
-   * corresponding bytearray is found for the resource.
+   * internal url handler that generates url to load inside its own resources, if exists. It
+   * overloads the openConnection to provide an input stream if a corresponding bytearray is found
+   * for the resource.
    */
   private final URLStreamHandler m_aURLStreamHandler = new URLStreamHandler ()
   {
@@ -104,8 +103,7 @@ public InputStream getInputStream () throws IOException
    * create a class loader with its parent.
    *
    * @param parent
-   *        the classloader to fall back when a resource or class definition
-   *        can't be found.
+   *        the classloader to fall back when a resource or class definition can't be found.
    */
   public DynamicClassLoader (final ClassLoader parent)
   {
@@ -127,8 +125,7 @@ public void setCode (@Nonnull final CompiledCodeJavaFile cc)
    * get the bytecode for a given class name.
    *
    * @param fullClassName
-   *        the full name of the class, including its package, eg
-   *        java.lang.String
+   *        the full name of the class, including its package, eg java.lang.String
    * @return the existing compiledCode for that class, or null.
    */
   public CompiledCodeJavaFile getCode (final String fullClassName)
@@ -171,7 +168,7 @@ protected URL findResource (final String sName)
       }
       catch (final MalformedURLException e)
       {
-        throw new UnsupportedOperationException ("catch this", e);
+        throw new UnsupportedOperationException (e);
       }
 
     return super.findResource (sName);

src/main/java/com/helger/jcodemodel/compile/MemoryCodeWriter.java

@@ -188,7 +188,7 @@ public ESuccess compile (@Nonnull final DynamicClassLoader aDynamicClassLoader)
         }
         catch (final Exception e1)
         {
-          throw new UnsupportedOperationException ("catch this exception", e1);
+          throw new UnsupportedOperationException (e1);
         }
       else
         aNonJava.put (e.getKey (), e.getValue ());
@@ -222,7 +222,7 @@ public ESuccess compile (@Nonnull final DynamicClassLoader aDynamicClassLoader)
       }
       catch (final Exception e1)
       {
-        throw new UnsupportedOperationException ("catch this exception", e1);
+        throw new UnsupportedOperationException (e1);
       }
     aDynamicClassLoader.addResources (aNonJava);
     return ESuccess.SUCCESS;
@@ -264,7 +264,7 @@ public static MemoryCodeWriter from (@Nonnull final JCodeModel jcm)
     }
     catch (final IOException e)
     {
-      throw new UnsupportedOperationException ("catch this exception", e);
+      throw new UnsupportedOperationException (e);
     }
     return codeWriter;
   }

src/test/java/com/helger/jcodemodel/ModelCopyTest.java

@@ -11,18 +11,18 @@
 import com.helger.jcodemodel.writer.StringCodeWriter;
 
 /**
- * abstract method for a test of copying. Such a test consist in creating a source codemodel, copying it, check the
- * equality of the representation of the copy and the source ; then apply several modifications on the source, each
- * result in a model varying from the copy ; then apply those modifications to the copy, which in the end should have
- * the same representation as the source.<br />
- *
+ * abstract method for a test of copying. Such a test consist in creating a source codemodel,
+ * copying it, check the equality of the representation of the copy and the source ; then apply
+ * several modifications on the source, each result in a model varying from the copy ; then apply
+ * those modifications to the copy, which in the end should have the same representation as the
+ * source.<br />
  * This class defines
  * <ul>
  * <li>{@link #execute()} that should be called in the test,</li>
  * <li>{@link #createCM()} that creates a base code model,</li>
  * <li>{@link #copy(JCodeModel)} that defines how to copy a {@link JCodeModel},</li>
  * <li>{@link #represent(JCodeModel)} to make a representation of a codemodel,</li>
- * <li> {@link #modifications()} that lists a series of modifications to apply.</li>
+ * <li>{@link #modifications()} that lists a series of modifications to apply.</li>
  * </ul>
  *
  * @author glelouet
@@ -33,15 +33,15 @@ public class ModelCopyTest
   @Test
   public void execute ()
   {
-    JCodeModel cm = createCM ();
-    JCodeModel copy = copy (cm);
+    final JCodeModel cm = createCM ();
+    final JCodeModel copy = copy (cm);
     Assert.assertEquals (represent (cm), represent (copy));
-    for (Consumer <JCodeModel> m : modifications ())
+    for (final Consumer <JCodeModel> m : modifications ())
     {
       m.accept (cm);
       Assert.assertNotEquals (represent (cm), represent (copy));
     }
-    for (Consumer <JCodeModel> m : modifications ())
+    for (final Consumer <JCodeModel> m : modifications ())
       m.accept (copy);
     Assert.assertEquals (represent (cm), represent (copy));
   }
@@ -50,65 +50,62 @@ protected JCodeModel createCM ()
   {
     try
     {
-      JCodeModel ret = new JCodeModel ();
+      final JCodeModel ret = new JCodeModel ();
 
       // create an interface IMyClass with method default String string(){return "yes";}
-      JDefinedClass itf = ret._class ("my.pckg.IMyClass", EClassType.INTERFACE);
-      JMethod methd = itf.method (JMod.PUBLIC | JMod.DEFAULT, ret.ref (String.class), "string");
+      final JDefinedClass itf = ret._class ("my.pckg.IMyClass", EClassType.INTERFACE);
+      final JMethod methd = itf.method (JMod.PUBLIC | JMod.DEFAULT, ret.ref (String.class), "string");
       methd.body ()._return (JExpr.lit ("yes"));
 
       // create an implementation of that interface, for which toString() returns the string();
-      JDefinedClass imp = itf._package ()._class (JMod.PUBLIC, "Impl")._implements (itf);
+      final JDefinedClass imp = itf._package ()._class (JMod.PUBLIC, "Impl")._implements (itf);
       imp.method (JMod.PUBLIC, ret.ref (String.class), "toString").body ()._return (JExpr.invoke (methd));
       return ret;
     }
-    catch (JCodeModelException e)
+    catch (final JCodeModelException e)
     {
-      throw new UnsupportedOperationException ("catch this", e);
+      throw new UnsupportedOperationException (e);
     }
   }
 
-  protected JCodeModel copy (JCodeModel source)
+  protected JCodeModel copy (final JCodeModel source)
   {
     return source.copy ();
   }
 
-  protected String represent (JCodeModel target)
+  protected String represent (final JCodeModel target)
   {
     return StringCodeWriter.represent (target);
   }
 
   public Collection <Consumer <JCodeModel>> modifications ()
   {
-    return Arrays.asList (cm ->
-    {
+    return Arrays.asList (cm -> {
       try
       {
         cm._class (JMod.PUBLIC, "MyClass");
       }
-      catch (JCodeModelException e)
+      catch (final JCodeModelException e)
       {
-        throw new UnsupportedOperationException ("catch this", e);
+        throw new UnsupportedOperationException (e);
       }
-    }, cm ->
-    {
-      JDefinedClass cl = cm._getClass ("my.pckg.IMyClass");
+    }, cm -> {
+      final JDefinedClass cl = cm._getClass ("my.pckg.IMyClass");
       cl.method (JMod.DEFAULT, cm.BOOLEAN, "yes").body ()._return (JExpr.TRUE);
-    }, cm ->
-    {
+    }, cm -> {
       try
       {
-        JDefinedClass cl = cm._getClass ("my.pckg.IMyClass");
-        JDefinedClass newcl = cl._class (JMod.STATIC | JMod.PUBLIC, "InternalIntClass");
-        JFieldVar fld = newcl.field (JMod.PRIVATE, cm.INT, "intField");
-        JMethod cons = newcl.constructor (JMod.PUBLIC);
-        JVar consParam = cons.param (cm.INT, "number");
+        final JDefinedClass cl = cm._getClass ("my.pckg.IMyClass");
+        final JDefinedClass newcl = cl._class (JMod.STATIC | JMod.PUBLIC, "InternalIntClass");
+        final JFieldVar fld = newcl.field (JMod.PRIVATE, cm.INT, "intField");
+        final JMethod cons = newcl.constructor (JMod.PUBLIC);
+        final JVar consParam = cons.param (cm.INT, "number");
         cons.body ().assign (fld, consParam);
         newcl.method (JMod.PUBLIC, cm.INT, "incr").body ()._return (JExpr.preincr (fld));
       }
-      catch (JCodeModelException e)
+      catch (final JCodeModelException e)
       {
-        throw new UnsupportedOperationException ("catch this", e);
+        throw new UnsupportedOperationException (e);
       }
     });
   }