Update pick/weightedPick typings to accept array-like objects#7258
Open
Bertie690 wants to merge 1 commit intophaserjs:masterfrom
Open
Update pick/weightedPick typings to accept array-like objects#7258Bertie690 wants to merge 1 commit intophaserjs:masterfrom
pick/weightedPick typings to accept array-like objects#7258Bertie690 wants to merge 1 commit intophaserjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7257
This PR:
Describe the changes below:
Updated typigs of relevant methods to allow passing in array-like objects like
TypedArrayandreadonlyarrays.Note
Low Risk
Low risk: this is a JSDoc/typing-only update (no runtime logic changes) that broadens accepted parameter types for
pick/weightedPickand refines thesignreturn type annotation.Overview
Updates
Phaser.Math.RandomDataGeneratorJSDoc generics sopickandweightedPickacceptArrayLike<T>(e.g., typed arrays / readonly arrays) instead of onlyT[].Refines the
signJSDoc return type fromnumberto the literal union-1 | 1for more accurate typings.Written by Cursor Bugbot for commit ab3f40f. This will update automatically on new commits. Configure here.