Skip to content

Conversation

@rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented May 1, 2025

Overview

This PR updates the rollup config, tsconfig and package to correctly export types.
Fixes #13

Preview

Types can now be imported as named imports:

import Phase, { CreateSecretOptions, GetSecretOptions, UpdateSecretOptions, DeleteSecretOptions } from "@phase.dev/phase-node";

And also work correctly with IDEs and linters:

Screenshot From 2025-05-01 13-41-01

Screenshot From 2025-05-01 13-41-40

@rohan-chaturvedi rohan-chaturvedi requested a review from nimish-ks May 1, 2025 08:14
@rohan-chaturvedi rohan-chaturvedi added bug Something isn't working enhancement New feature or request labels May 1, 2025
@rohan-chaturvedi rohan-chaturvedi merged commit c1bc237 into main May 1, 2025
1 check passed
@rohan-chaturvedi rohan-chaturvedi deleted the fix--export-types branch May 1, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type GetSecretOptions Not Exported and Incorrect Library Reference in Documentation

3 participants