Skip to content

Commit 29e4832

Browse files
committed
fix: improve error handling in secret resolution by logging warnings instead of throwing errors
1 parent 31e8ffc commit 29e4832

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/utils/secretReferencing.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ export async function resolveSecretReferences(
7676

7777
// Check for circular references
7878
if (resolutionStack.has(cacheKey)) {
79-
throw new Error(`Circular reference detected: ${ref[0]}${cacheKey}`);
79+
console.warn(`Circular reference detected: ${ref[0]}${cacheKey}`);
80+
continue;
8081
}
8182

8283
// Resolve the reference if not in cache
@@ -99,7 +100,9 @@ export async function resolveSecretReferences(
99100

100101
cache.set(cacheKey, resolvedSecretValue);
101102
} catch (error: any) {
102-
throw new Error(`Failed to resolve reference ${ref[0]}: ${error.message || error}`);
103+
console.warn(`Failed to resolve reference ${ref[0]}: ${error.message || error}`);
104+
resolutionStack.delete(cacheKey);
105+
continue;
103106
} finally {
104107
resolutionStack.delete(cacheKey);
105108
}
@@ -108,10 +111,7 @@ export async function resolveSecretReferences(
108111
// Replace the reference with its resolved value
109112
resolvedValue = resolvedValue.replace(ref[0], cache.get(cacheKey)!);
110113
} catch (error: any) {
111-
if (!error.message?.includes('Failed to resolve reference')) {
112-
error = new Error(`Error resolving reference ${ref[0]}: ${error.message || error}`);
113-
}
114-
throw error;
114+
console.warn(`Error resolving reference ${ref[0]}: ${error.message || error}`);
115115
}
116116
}
117117

0 commit comments

Comments
 (0)