Merge pull request #98 from phaseLineStudios/feature/performance-improvements

Feature/performance improvements

Author: GianRathgeb

src/assets/shaders/MapPaper.gdshader

@@ -0,0 +1,32 @@
+shader_type spatial;
+
+render_mode cull_disabled;
+
+uniform sampler2D map_tex : source_color, filter_linear_mipmap_anisotropic, repeat_disable;
+uniform float brightness : hint_range(0.0, 1.0) = 0.88;
+uniform float contrast : hint_range(0.0, 2.0) = 1.06;
+uniform float sharpen_strength : hint_range(0.0, 3.0) = 0.65;
+uniform float unshaded : hint_range(0.0, 1.0) = 0.0;
+
+void fragment() {
+	vec2 texel = 1.0 / vec2(textureSize(map_tex, 0));
+
+	vec3 c = texture(map_tex, UV).rgb;
+	vec3 b = (
+		texture(map_tex, UV + vec2(texel.x, 0.0)).rgb
+		+ texture(map_tex, UV - vec2(texel.x, 0.0)).rgb
+		+ texture(map_tex, UV + vec2(0.0, texel.y)).rgb
+		+ texture(map_tex, UV - vec2(0.0, texel.y)).rgb
+	) * 0.25;
+
+	vec3 col = c + (c - b) * sharpen_strength;
+	col = (col - vec3(0.5)) * contrast + vec3(0.5);
+	col = clamp(col * brightness, 0.0, 1.0);
+
+	ALBEDO = col * (1.0 - unshaded);
+	EMISSION = col * unshaded;
+
+	ROUGHNESS = 1.0;
+	METALLIC = 0.0;
+	SPECULAR = 0.0;
+}

src/assets/shaders/MapPaper.gdshader.uid

@@ -0,0 +1 @@
+uid://7bkjmqdec1go

src/scenes/system/unit_counter.tscn

@@ -54,7 +54,7 @@ unique_name_in_owner = true
 disable_3d = true
 transparent_bg = true
 size = Vector2i(2048, 2048)
-render_target_update_mode = 4
+render_target_update_mode = 0
 
 [node name="Background" type="PanelContainer" parent="FaceRenderer"]
 unique_name_in_owner = true

src/scenes/ui/viewport_read_overlay.tscn

@@ -0,0 +1,60 @@
+[gd_scene load_steps=2 format=3]
+
+[ext_resource type="Script" path="res://scripts/ui/ViewportReadOverlay.gd" id="1_overlay"]
+
+[node name="ViewportReadOverlay" type="CanvasLayer"]
+layer = 50
+script = ExtResource("1_overlay")
+
+[node name="Root" type="Control" parent="."]
+anchors_preset = 15
+anchor_right = 1.0
+anchor_bottom = 1.0
+mouse_filter = 0
+
+[node name="Background" type="ColorRect" parent="Root"]
+anchors_preset = 15
+anchor_right = 1.0
+anchor_bottom = 1.0
+mouse_filter = 0
+color = Color(0, 0, 0, 0.65)
+
+[node name="Margin" type="MarginContainer" parent="Root"]
+anchors_preset = 15
+anchor_right = 1.0
+anchor_bottom = 1.0
+mouse_filter = 0
+theme_override_constants/margin_left = 80
+theme_override_constants/margin_top = 60
+theme_override_constants/margin_right = 80
+theme_override_constants/margin_bottom = 60
+
+[node name="Panel" type="PanelContainer" parent="Root/Margin"]
+layout_mode = 2
+mouse_filter = 0
+
+[node name="VBox" type="VBoxContainer" parent="Root/Margin/Panel"]
+layout_mode = 2
+mouse_filter = 0
+
+[node name="TopBar" type="HBoxContainer" parent="Root/Margin/Panel/VBox"]
+layout_mode = 2
+mouse_filter = 0
+
+[node name="TitleLabel" type="Label" parent="Root/Margin/Panel/VBox/TopBar"]
+unique_name_in_owner = true
+layout_mode = 2
+size_flags_horizontal = 3
+text = "View"
+
+[node name="CloseButton" type="Button" parent="Root/Margin/Panel/VBox/TopBar"]
+unique_name_in_owner = true
+layout_mode = 2
+text = "Close"
+
+[node name="ViewportTexture" type="TextureRect" parent="Root/Margin/Panel/VBox"]
+unique_name_in_owner = true
+layout_mode = 2
+size_flags_horizontal = 3
+size_flags_vertical = 3
+mouse_filter = 0

src/scripts/core/DocumentController.gd

@@ -26,6 +26,12 @@ const MAX_TRANSCRIPT_ENTRIES := 50
 ## Refresh delay in seconds (wait for user to stop navigating)
 const REFRESH_DELAY := 0.15
 
+@export_group("Performance")
+## If true, bake a CPU ImageTexture with mipmaps from the viewport (expensive).
+@export var bake_viewport_mipmaps: bool = false
+## Delay before rebuilding transcript pages after new entries (seconds).
+@export var transcript_update_delay_sec: float = 0.25
+
 ## Sound to play when page is changed.
 @export var page_change_sounds: Array[AudioStream] = [
 	preload("res://audio/sfx/sfx_paper_flip_01.wav"),
@@ -69,7 +75,7 @@ var _transcript_entries: Array[Dictionary] = []
 
 ## Transcript update mutex to prevent concurrent updates
 var _transcript_updating := false
-var _transcript_pending_entries: Array[Dictionary] = []
+var _transcript_update_needs_rerun := false
 
 ## Current scenario reference
 var _scenario: ScenarioData
@@ -85,6 +91,7 @@ var _briefing_material: StandardMaterial3D
 ## Debounce timers for texture refresh
 var _intel_refresh_timer: Timer
 var _transcript_refresh_timer: Timer
+var _transcript_update_timer: Timer
 var _briefing_refresh_timer: Timer
 
 
@@ -126,24 +133,30 @@ func _setup_viewports() -> void:
 	_intel_viewport = SubViewport.new()
 	_intel_viewport.size = render_size
 	_intel_viewport.transparent_bg = false
-	_intel_viewport.render_target_update_mode = SubViewport.UPDATE_ALWAYS
+	_intel_viewport.render_target_update_mode = SubViewport.UPDATE_DISABLED
 	_intel_viewport.gui_disable_input = false
+	_intel_viewport.msaa_2d = Viewport.MSAA_2X
+	_intel_viewport.screen_space_aa = Viewport.SCREEN_SPACE_AA_DISABLED
 	add_child(_intel_viewport)
 
 	# Transcript viewport
 	_transcript_viewport = SubViewport.new()
 	_transcript_viewport.size = render_size
 	_transcript_viewport.transparent_bg = false
-	_transcript_viewport.render_target_update_mode = SubViewport.UPDATE_ALWAYS
+	_transcript_viewport.render_target_update_mode = SubViewport.UPDATE_DISABLED
 	_transcript_viewport.gui_disable_input = false
+	_transcript_viewport.msaa_2d = Viewport.MSAA_2X
+	_transcript_viewport.screen_space_aa = Viewport.SCREEN_SPACE_AA_DISABLED
 	add_child(_transcript_viewport)
 
 	# Briefing viewport
 	_briefing_viewport = SubViewport.new()
 	_briefing_viewport.size = render_size
 	_briefing_viewport.transparent_bg = false
-	_briefing_viewport.render_target_update_mode = SubViewport.UPDATE_ALWAYS
+	_briefing_viewport.render_target_update_mode = SubViewport.UPDATE_DISABLED
 	_briefing_viewport.gui_disable_input = false
+	_briefing_viewport.msaa_2d = Viewport.MSAA_2X
+	_briefing_viewport.screen_space_aa = Viewport.SCREEN_SPACE_AA_DISABLED
 	add_child(_briefing_viewport)
 
 
@@ -163,6 +176,13 @@ func _setup_refresh_timers() -> void:
 	_transcript_refresh_timer.timeout.connect(_do_transcript_refresh)
 	add_child(_transcript_refresh_timer)
 
+	# Transcript update timer (coalesce new entries)
+	_transcript_update_timer = Timer.new()
+	_transcript_update_timer.wait_time = maxf(transcript_update_delay_sec, 0.01)
+	_transcript_update_timer.one_shot = true
+	_transcript_update_timer.timeout.connect(_do_transcript_update)
+	add_child(_transcript_update_timer)
+
 	# Briefing timer
 	_briefing_refresh_timer = Timer.new()
 	_briefing_refresh_timer.wait_time = REFRESH_DELAY
@@ -375,24 +395,25 @@ func _update_transcript_content(follow_new_messages: bool) -> void:
 	_transcript_face.update_page_indicator()
 	_display_page(_transcript_face, _transcript_content, _transcript_pages, target_page)
 
-	# Refresh texture immediately for transcript updates (no debounce needed)
-	await _do_transcript_refresh()
+	if _transcript_refresh_timer:
+		_transcript_refresh_timer.start()
 
 
-## Add a radio transmission to the transcript
-## [param speaker] Who is speaking (e.g., "PLAYER", "ALPHA", "HQ")
-## [param message] The message text
-func add_transcript_entry(speaker: String, message: String) -> void:
-	var timestamp := _get_mission_timestamp()
-	var entry := {"timestamp": timestamp, "speaker": speaker, "message": message}
-
-	_transcript_entries.append(entry)
+func _queue_transcript_update() -> void:
+	if _transcript_update_timer == null:
+		return
+	if _transcript_updating:
+		_transcript_update_needs_rerun = true
+		return
+	_transcript_update_timer.wait_time = maxf(transcript_update_delay_sec, 0.01)
+	if not _transcript_update_timer.is_stopped():
+		return
+	_transcript_update_timer.start()
 
-	if _transcript_entries.size() > MAX_TRANSCRIPT_ENTRIES:
-		_transcript_entries.pop_front()
 
+func _do_transcript_update() -> void:
 	if _transcript_updating:
-		_transcript_pending_entries.append(entry)
+		_transcript_update_needs_rerun = true
 		return
 
 	_transcript_updating = true
@@ -405,22 +426,24 @@ func add_transcript_entry(speaker: String, message: String) -> void:
 
 	_transcript_updating = false
 
-	if _transcript_pending_entries.size() > 0:
-		_transcript_pending_entries.clear()
-		await _refresh_transcript_display()
+	if _transcript_update_needs_rerun:
+		_transcript_update_needs_rerun = false
+		_queue_transcript_update()
 
 
-## Refresh transcript display without adding new entries
-func _refresh_transcript_display() -> void:
-	_transcript_updating = true
+## Add a radio transmission to the transcript
+## [param speaker] Who is speaking (e.g., "PLAYER", "ALPHA", "HQ")
+## [param message] The message text
+func add_transcript_entry(speaker: String, message: String) -> void:
+	var timestamp: String = _get_mission_timestamp()
+	var entry: Dictionary = {"timestamp": timestamp, "speaker": speaker, "message": message}
 
-	var was_on_last_page := false
-	if _transcript_face and _transcript_pages.size() > 0:
-		was_on_last_page = _transcript_face.current_page >= _transcript_pages.size() - 1
+	_transcript_entries.append(entry)
 
-	await _update_transcript_content(was_on_last_page)
+	if _transcript_entries.size() > MAX_TRANSCRIPT_ENTRIES:
+		_transcript_entries.pop_front()
 
-	_transcript_updating = false
+	_queue_transcript_update()
 
 
 ## Get current mission timestamp as formatted string
@@ -434,6 +457,14 @@ func _get_mission_timestamp() -> String:
 
 ## Apply rendered textures to clipboard materials
 func _apply_textures() -> void:
+	# Render each SubViewport once before capturing to textures.
+	if _intel_viewport:
+		_intel_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
+	if _transcript_viewport:
+		_transcript_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
+	if _briefing_viewport:
+		_briefing_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
+
 	await get_tree().process_frame
 	await get_tree().process_frame  # Extra frame to ensure render complete
 
@@ -445,6 +476,7 @@ func _apply_textures() -> void:
 ## Refresh the transcript document texture after content updates
 func _refresh_transcript_texture() -> void:
 	if _transcript_material and _transcript_viewport:
+		_transcript_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
 		await get_tree().process_frame  # Wait for render
 		_refresh_texture(_transcript_material, _transcript_viewport)
 
@@ -492,6 +524,22 @@ func _refresh_texture(material: StandardMaterial3D, viewport: SubViewport) -> vo
 		LogService.warning("Cannot refresh: material or viewport is null", "DocumentController.gd")
 		return
 
+	# Reduce glare so text stays readable under strong lights.
+	material.albedo_color = Color.WHITE
+	material.metallic = 0.0
+	material.roughness = 1.0
+	material.specular = 0.0
+
+	material.texture_filter = (
+		BaseMaterial3D.TEXTURE_FILTER_LINEAR_WITH_MIPMAPS_ANISOTROPIC
+		if bake_viewport_mipmaps
+		else BaseMaterial3D.TEXTURE_FILTER_LINEAR
+	)
+
+	if not bake_viewport_mipmaps:
+		material.albedo_texture = viewport.get_texture()
+		return
+
 	var img := viewport.get_texture().get_image()
 	if img == null:
 		LogService.warning("Failed to get image from viewport", "DocumentController.gd")
@@ -713,18 +761,24 @@ func _on_briefing_page_changed(page_index: int) -> void:
 
 ## Debounced refresh functions - called after timer expires
 func _do_intel_refresh() -> void:
+	if _intel_viewport:
+		_intel_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
 	await get_tree().process_frame
 	await get_tree().process_frame
 	_refresh_texture(_intel_material, _intel_viewport)
 
 
 func _do_transcript_refresh() -> void:
+	if _transcript_viewport:
+		_transcript_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
 	await get_tree().process_frame
 	await get_tree().process_frame
 	_refresh_texture(_transcript_material, _transcript_viewport)
 
 
 func _do_briefing_refresh() -> void:
+	if _briefing_viewport:
+		_briefing_viewport.render_target_update_mode = SubViewport.UPDATE_ONCE
 	await get_tree().process_frame
 	await get_tree().process_frame
 	_refresh_texture(_briefing_material, _briefing_viewport)