Breaking sin debug session inheritance refactoring #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now SindarinDebugSession are created from existing debug sessions. This breaks Sindarin.
…and updating references to "self" by pointing them to the original debug session.
…essor to the debug session of SindarinDebugSession, that now delegates debug session behavior to a real debug session
- reformating (and removing points from end statements) - flagging
- renaming ScriptableDebuggerTest to SindarinDebuggerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
SindarinDebugSessionis not a subclass ofDebugSessionanymore, but delegates to an instance ofDebugSessioninstead.Also did a pass over tests.