-
Notifications
You must be signed in to change notification settings - Fork 74
adding copy systen info into clipboard under debugger right click menu #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Pharo14
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,41 @@ | |||
| Class { | |||
| #name : 'SindarinCopyOsInfo', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really specific to Sindarin to copy some infos?
Seems like something more general than Sindarin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to have it on all menus.
According to the issue we want to be able to report system info from a debugger window when an error is raised, to help documenting a new issue about it.
This way we avoid carrying an extra entry in the right click menu elsewhere where it isn't used as much as on a debugger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you Faouzi but what Cyril means is that it maybe should be at the "general debugger" level rather than on Sindarin.
That's another subject but in my opinion Sindarin should be removed from the system, and be an external, optional project. If that ever happens, should we still want to have the feature you propose available in the debugger?
If that is so, then it just means you have to rename and move your command class in the debugger packages with other commands ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah now i see what you mean, in this case i'll try to move the command into the debugger. Thanks for clearing this up for me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steven about sindarin, let us know. I liked the idea of being able to script the debugger.
What I can tell you is that with debug info we paid attention not to break it.
If it is out of Pharo, it will be probably difficult to maintain it. Now I think that for debug info we will not do more changes. so may be we could remove it when the debugger can use offlinedebuginfo like that it will be in a good shape for the future.
| Clipboard clipboardText: self systemInfo. | ||
| ] | ||
|
|
||
| { #category : 'as yet unclassified' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No as yet unclassified
|
@fouziray @Julesboul can you reply to @jecisc and do the next step? |
|
About this menu item. I have a question what is the different with the information from the About. |
fix #549 by adding a new command in the right-click menu in a debugger window.
@Julesboul @DurieuxPol