Skip to content

New methods added #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pankaj-bind
Copy link

fix #31
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14798591735

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.764%

Totals Coverage Status
Change from base Build 11551680919: 0.0%
Covered Lines: 812
Relevant Lines: 1018

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14798591735

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.764%

Totals Coverage Status
Change from base Build 11551680919: 0.0%
Covered Lines: 812
Relevant Lines: 1018

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2025

Pull Request Test Coverage Report for Build 14812414249

Details

  • 60 of 96 (62.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 77.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Array2D/CTAlternateArray2D.class.st 60 65 92.31%
src/Containers-Array2D/CTArray2D.class.st 0 31 0.0%
Totals Coverage Status
Change from base Build 11551680919: -2.7%
Covered Lines: 813
Relevant Lines: 1055

💛 - Coveralls

@pankaj-bind
Copy link
Author

@jordanmontt all issues have been resolved, now you can merge this PR and CI of edit-distances will become green

@jordanmontt
Copy link

Capture d’écran 2025-05-03 à 17 04 24 The methods are still as extensions. Which is weird...

@pankaj-bind
Copy link
Author

pankaj-bind commented May 3, 2025

wait for some time, do not merge this PR, I will make an update

@pankaj-bind
Copy link
Author

@jordanmontt Now it's ready to go

@jordanmontt
Copy link

@Ducasse I would like your review on this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new methods to fix CI
3 participants