criteria: fix issue #2157 and added tests #2220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion here:
http://forum.phalconphp.com/discussion/1479/multiple-joins-in-oo-notation-fail
From what I saw, the problem was that the
current_joins
was merged with thejoin
array instead of appended, so it resulted in something like this:instead of
I don't know how to copy a zval and I'm guessing I couldn't edit
current_joins
directly, so to avoid editing too much code I simpy added an array of array that can be merged withcurrent_joins
or copy-written onmerged_joins
.