Skip to content

T15067 Fix controller name parsing route #15770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2021
Merged

T15067 Fix controller name parsing route #15770

merged 3 commits into from
Nov 7, 2021

Conversation

BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented Nov 7, 2021 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
String format router definition processing is different for controller name because of uncamelize of this option.
Removed uncamelize.

Thanks

@BeMySlaveDarlin BeMySlaveDarlin added breaks bc Functionality that breaks Backwards Compatibility 5.0 The issues we want to solve in the 5.0 release labels Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin self-assigned this Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin changed the base branch from master to 5.0.x November 7, 2021 11:04
@BeMySlaveDarlin BeMySlaveDarlin changed the title Issue/15067 fix controller name parsing router T15067 Fix controller name parsing route Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin linked an issue Nov 7, 2021 that may be closed by this pull request
[BUG]: The routing controller name changes when using syntax sugar. #15067
Closed
@niden niden added bug A bug report status: low Low labels Nov 7, 2021
@niden niden merged commit cfcb101 into phalcon:5.0.x Nov 7, 2021
@niden
Copy link
Member

niden commented Nov 7, 2021

Thank you @BeMySlaveDarlin

@niden niden mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@Jeckerson Jeckerson Awaiting requested review from Jeckerson

@zsilbi zsilbi Awaiting requested review from zsilbi

Assignees

@BeMySlaveDarlin BeMySlaveDarlin

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: The routing controller name changes when using syntax sugar.
2 participants
@BeMySlaveDarlin @niden