T15567 Form entity not passed with validation #15568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stijn1989 Could you write a test case with scenario that you described in a changelog? |
What do you mean by testcase? A unit test or a real life example? I provided an example in the issue. |
|
Unit test |
Unit test is added to the branch. |
|
@stijn1989 Your test is failing, could you please check? |
Yeah I'm not great in writing tests. I forgot to create a DI container in the test. |
Pass the form entity to validation if no entity is provided with the isValid method.
Syntax error
create factory default DI
Refs [#atch]
Refs [#atch]
niden
approved these changes
Aug 12, 2021
|
Thank you @stijn1989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following:
Assign the form entity to the entity variable in the isValid method if no entity is provided.