Skip to content

#15363 - Fix db delete with passed bindTypes #15479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jeckerson merged 5 commits into from
May 10, 2021
Merged

#15363 - Fix db delete with passed bindTypes #15479

Jeckerson merged 5 commits into from
May 10, 2021

Conversation

@Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented May 10, 2021

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Thanks

@Jeckerson Jeckerson added bug A bug report status: high High 5.0 The issues we want to solve in the 5.0 release labels May 10, 2021
@Jeckerson Jeckerson requested a review from niden May 10, 2021 19:01
@Jeckerson Jeckerson self-assigned this May 10, 2021
@Jeckerson Jeckerson linked an issue May 10, 2021 that may be closed by this pull request
[BUG]: PHP 8 db->delete throw exception if not pass empty array #15363
Closed
@Jeckerson Jeckerson mentioned this pull request May 10, 2021
Closed
niden
niden previously approved these changes May 10, 2021
View reviewed changes
@Jeckerson
Merge branch '5.0.x' into #15363-fix-db-delete
e352198 
# Conflicts:
#	CHANGELOG-5.0.md
@Jeckerson Jeckerson merged commit 8912fe9 into 5.0.x May 10, 2021
@Jeckerson Jeckerson deleted the #15363-fix-db-delete branch May 10, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: PHP 8 db->delete throw exception if not pass empty array

3 participants

@Jeckerson @niden