Skip to content

test(image/adapter/gd): added test for text with font #15418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 21, 2021
Merged

test(image/adapter/gd): added test for text with font #15418

merged 6 commits into from
Apr 21, 2021

Conversation

@niden
Copy link
Member

@niden niden commented Apr 20, 2021 •
edited
Loading

Refs [#15188]

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

--

Corrected Phalcon\Image\Adapter\Gd::processText to correctly call imagettfbbox when a font is specified

@niden niden linked an issue Apr 20, 2021 that may be closed by this pull request
[BUG]: Phalcon\Image\Adapter\Gd throwing an exception for the text function #15188
Closed
@niden niden self-assigned this Apr 20, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Apr 20, 2021
@niden niden requested a review from Jeckerson April 21, 2021 00:17
@Jeckerson Jeckerson mentioned this pull request Apr 21, 2021
Closed
@niden niden merged commit dbd1802 into phalcon:5.0.x Apr 21, 2021
@niden niden deleted the T15188-gd-text branch April 21, 2021 13:09
@niden niden mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Image\Adapter\Gd throwing an exception for the text function

2 participants

@niden @Jeckerson