Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(logger/formatter/line): added test with a different line format #15401

Merged
merged 4 commits into from
Apr 19, 2021
Merged

test(logger/formatter/line): added test with a different line format #15401

merged 4 commits into from
Apr 19, 2021

Conversation

niden
Copy link
Member

@niden niden commented Apr 14, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Wrote test to identify if this is an issue or not

Thanks

@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: unverified Unverified labels Apr 14, 2021
@niden niden linked an issue Apr 14, 2021 that may be closed by this pull request
[BUG]: Logger variable %type% not in uppercase #15375
Closed
@niden niden mentioned this pull request Apr 14, 2021
Closed
Jeckerson
Jeckerson previously approved these changes Apr 15, 2021
View reviewed changes
@niden niden merged commit 0d8e2b6 into phalcon:5.0.x Apr 19, 2021
@niden niden deleted the T15375-logger-type branch April 19, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: unverified Unverified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Logger variable %type% not in uppercase
2 participants
@niden @Jeckerson