Skip to content

T15038 factory newinstance #15039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2020
Merged

T15038 factory newinstance #15039

merged 2 commits into from
May 13, 2020

Conversation

@niden
Copy link
Member

@niden niden commented May 13, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Factory\AbstractFactory to expose getService which will throw an exception if it does not exist. Removed checkService and adjusted all references in newInstance() calls. [

Thanks

@niden niden changed the base branch from master to 4.0.x May 13, 2020 18:05
@niden niden linked an issue May 13, 2020 that may be closed by this pull request
Improve Phalcon\Translate\InterpolatorFactory::newInstance #15038
Closed
@niden niden added 4.0.6 enhancement Enhancement to the framework labels May 13, 2020
@niden niden merged commit 375b25e into phalcon:4.0.x May 13, 2020
@niden niden deleted the T15038-factory-newinstance branch May 13, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergeyklay sergeyklay sergeyklay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Enhancement to the framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Phalcon\Translate\InterpolatorFactory::newInstance

2 participants

@niden @sergeyklay