Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cache] - Cache Serializer options #14828

Merged
merged 2 commits into from
Feb 9, 2020
Merged

[cache] - Cache Serializer options #14828

merged 2 commits into from
Feb 9, 2020

Conversation

niden
Copy link
Member

@niden niden commented Feb 9, 2020 •
edited
Loading

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Storage\Adapter\* to no longer accept the serializer option as it was clashing with the factory

Thanks

@niden niden self-assigned this Feb 9, 2020
@niden niden added 4.0.4 bug A bug report status: low Low labels Feb 9, 2020
@niden niden changed the title [cache] - Removed option to set the serializer from the options - col… [cache] - Cache Serializer options Feb 9, 2020
@niden niden merged commit 470383b into phalcon:4.0.x Feb 9, 2020
@niden niden deleted the cache-serializer-options branch March 16, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson