Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cache key #14457

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Fix/cache key #14457

merged 3 commits into from
Oct 11, 2019

Conversation

ekmst
Copy link
Contributor

@ekmst ekmst commented Oct 11, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change: added missed . to key pattern
see

Thanks

@niden
Copy link
Member

niden commented Oct 11, 2019

@ekmst Thank you for this. If you don't mind update the changelog also.

@niden niden added 4.0 enhancement Enhancement to the framework labels Oct 11, 2019
@niden niden merged commit df5bc7c into phalcon:4.0.x Oct 11, 2019
@niden
Copy link
Member

niden commented Oct 11, 2019

Thank you @ekmst !

@ekmst ekmst deleted the fix/cache-key branch October 11, 2019 00:23
@PutinVladimir
Copy link

PutinVladimir commented Oct 11, 2019

Do not follow blindly PSR.

There told must at least support this chars, but not should be limited this chars and "MAY support additional characters and encodings".
So you limited to cache content of page where page name or page url in national characters as cache key.

Also in PSR told "The following characters are reserved for future extensions and MUST NOT be supported by implementing libraries: {}()/@:" but most of this symbols correctly worked in apcu, memcached, redis and at least ":", "/" needed for whole page caching by url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants