Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13697 remove mongo from 4.0 #14361

Merged
merged 10 commits into from
Sep 7, 2019
Merged

T13697 remove mongo from 4.0 #14361

merged 10 commits into from
Sep 7, 2019

Conversation

niden
Copy link
Member

@niden niden commented Sep 7, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed the mongo collection classes from v4 since they are outdated. There is already work for the new version of the mongo driver in #13697 for 4.1

Thanks

@niden niden changed the base branch from master to 4.0.x September 7, 2019 15:42
@niden niden added 4.0 enhancement Enhancement to the framework labels Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #14361 into 4.0.x will increase coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14361      +/-   ##
==========================================
+ Coverage   66.29%   67.82%   +1.53%     
==========================================
  Files         487      477      -10     
  Lines      115843   113127    -2716     
==========================================
- Hits        76801    76732      -69     
+ Misses      39042    36395    -2647

@niden niden merged commit bd56301 into phalcon:4.0.x Sep 7, 2019
@niden niden deleted the T13697-remove-mongo-from-4.0 branch September 12, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants