Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-7 - Tests and refactoring #14154

Merged
merged 16 commits into from
Jun 3, 2019
Merged

PSR-7 - Tests and refactoring #14154

merged 16 commits into from
Jun 3, 2019

Conversation

niden
Copy link
Member

@niden niden commented Jun 3, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

niden added 12 commits June 2, 2019 11:57
@niden
Changed Http\Payload to Domain\Payload; Refactored the Collection cla…
7169659 
…ss; Added tests
@niden
Domain\Payload corrections and tests
df5fa9f
@niden
Added common abstract class; Refactor on factories
93003f5
@niden
Refactored/corrected Uri
11d372b
@niden
Changed getters with zephir get syntax
cf90256
@niden
Corrections to the classes; minor adjustments
063e319
@niden
Numerous corrections; Added ServerRequestFactory::load
ff027b1
@niden
Added/Adjusted PSR7/17 tests
691f2b8
@niden
Removed typos from the code - unecessary $ signs
ed325f0
@niden
Corrections to Collection and related tests
f2e1f9f
@niden
Yuuge refactor
79da1f5 
Introduced new `load` method for ServerRequestFactory to load from superglobals
Refactored Collection to allow conditional key case sensitivity
Introduced ReadCollection
Refactored Registry to align with Collection
Moved Collection to its own namespace
Loads of tests with more code coverage
@niden
Updating the changelog
3406be9
@niden niden added documentation Documentation required new feature request Planned Feature or New Feature Request testing Tests related issue labels Jun 3, 2019
@niden niden merged commit 8b0dec0 into phalcon:4.0.x Jun 3, 2019
@niden niden deleted the tests-refactoring branch September 12, 2019 21:45
@niden niden added 4.0 and removed documentation Documentation required labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request testing Tests related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niden