Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger\Adapter\AbstractAdapter::process() is now actually abstract. #14012

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Logger\Adapter\AbstractAdapter::process() is now actually abstract. #14012

merged 1 commit into from
Apr 23, 2019

Conversation

SidRoberts
Copy link
Contributor

Hello!

  • Type: bug fix | code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@niden niden added the enhancement Enhancement to the framework label Apr 23, 2019
@niden niden merged commit 47ec1f7 into phalcon:4.0.x Apr 23, 2019
@niden
Copy link
Member

niden commented Apr 23, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the log-abstract branch April 23, 2019 23:43
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgofx virgofx virgofx approved these changes

@sergeyklay sergeyklay sergeyklay approved these changes

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SidRoberts @niden @virgofx @sergeyklay @Jeckerson