Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The property 'options' is always an array in Model Relations. #13989

Merged
merged 2 commits into from
Apr 23, 2019
Merged

The property 'options' is always an array in Model Relations. #13989

merged 2 commits into from
Apr 23, 2019

Conversation

SidRoberts
Copy link
Contributor

@SidRoberts SidRoberts commented Apr 15, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #13989 into 4.0.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13989      +/-   ##
==========================================
+ Coverage   67.92%   67.94%   +0.01%     
==========================================
  Files         469      469              
  Lines       94258    94255       -3     
==========================================
+ Hits        64027    64043      +16     
+ Misses      30231    30212      -19
Impacted Files Coverage Δ
ext/phalcon/mvc/model/relation.zep.c 84.93% <0%> (+10.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a60f2...e0a3ed1. Read the comment docs.

@sergeyklay
Copy link
Contributor

@SidRoberts Could you please rebase

@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Apr 23, 2019
@niden niden merged commit 357293f into phalcon:4.0.x Apr 23, 2019
@niden
Copy link
Member

niden commented Apr 23, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the model-relation branch June 8, 2019 08:02
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants