Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations\Reader::parse() always returns an array. #13923

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Annotations\Reader::parse() always returns an array. #13923

merged 1 commit into from
Mar 31, 2019

Conversation

SidRoberts
Copy link
Contributor

Hello!

  • Type: code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Small description of change:

Annotations\Reader::parse() always returns an array so we don't need to check if it is.

Thanks

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #13923 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13923      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         468      468              
  Lines       94022    94021       -1     
==========================================
- Hits        63518    63517       -1     
  Misses      30504    30504
Impacted Files Coverage Δ
ext/phalcon/annotations/adapter.zep.c 47.82% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f041409...c02f324. Read the comment docs.

@niden niden merged commit 828d7ee into phalcon:4.0.x Mar 31, 2019
@niden
Copy link
Member

niden commented Mar 31, 2019

Thank you @SidRoberts

@niden niden added the enhancement Enhancement to the framework label Apr 5, 2019
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants