-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compatibility issue. #13911
Merged
Merged
Fixed compatibility issue. #13911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setImageAlpha () - fills the alpha channel with black before execution. valuImage () is the best compatibility.
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13911 +/- ##
==========================================
+ Coverage 67.85% 67.85% +<.01%
==========================================
Files 468 468
Lines 93380 93378 -2
==========================================
Hits 63365 63365
+ Misses 30015 30013 -2
Continue to review full report at Codecov.
|
sergeyklay
approved these changes
Mar 21, 2019
Jeckerson
approved these changes
Mar 21, 2019
@shum0531 Can you please add a line to the CHANGELOG-v4 of what this PR does? |
shum0531
added a commit
to shum0531/cphalcon
that referenced
this pull request
Mar 22, 2019
shum0531
added a commit
to shum0531/cphalcon
that referenced
this pull request
Mar 22, 2019
Thank you @shum0531 |
sergeyklay
added a commit
that referenced
this pull request
Mar 22, 2019
[#13911] Added changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
setImageAlpha () - fills the alpha channel with black before execution.
evaluateImage () is the best compatibility.
Thanks