Fixed #13552: Overwriting columns with the same alias #13663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: Fixed
Phalcon\Mvc\Model\Query::_prepareSelect
overwriting columns with the same alias. This specific issue only appeared when you were selecting columns acrossdifferent tables with the same column name. The generated alias didn't factor in the different tables and any columns with the same name would get overridden.
Take this example from
Phalcon\Test\Integration\Paginator\Adapter::testIssue13552
. This snippet would generate the SQL below when the paginator tries to find out the total items.Before:
After:
Thanks