Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aliases for ciphers in Phalcon\Crypt #12539

Merged
merged 5 commits into from
Jan 12, 2017
Merged

Add Aliases for ciphers in Phalcon\Crypt #12539

merged 5 commits into from
Jan 12, 2017

Conversation

ibpavlov
Copy link
Contributor

@ibpavlov ibpavlov commented Jan 12, 2017

Hello!

  • Type: bug fix | code quality

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:
The old versions supported aliases of ciphers and now it doesn't. They are easier to use and migration will be easier for those who use this class.

Thanks

The older version of Phalcon used aliases for cipher and now they are not available. They are easy to use and migration will be easier if they persist.
@Jurigag
Copy link
Contributor

Jurigag commented Jan 12, 2017

Update changelog too. Also we don't accept PRs to master branch. Please send it to 3.0.x.

@sergeyklay
Copy link
Contributor

  1. We don't add changes directly to stable branches or master. Could you please send this PR to the 3.0.x branch?
  2. Could you please update CHANGELOG.md

@sergeyklay sergeyklay added this to the 3.0.4 milestone Jan 12, 2017
@ibpavlov ibpavlov changed the base branch from master to 3.0.x January 12, 2017 13:09
@ibpavlov
Copy link
Contributor Author

I see that on 3.0.x are only fixes. If I have to I can change it to 3.1.x.
I'm sorry that I do things slow, but this is my first official pull-request.

@Jurigag
Copy link
Contributor

Jurigag commented Jan 12, 2017

Well you wrote this is bug fix, so it's for 3.0.x, not sure which exactly bug it's fixing.

@ibpavlov
Copy link
Contributor Author

When I migrated my application to Phalcon 3.0.x it gave me an exception. These changes fixed the issue. I've decided to try and contribute it directly and not to create an issue in the system for someone else to solve.

@Jurigag
Copy link
Contributor

Jurigag commented Jan 12, 2017

Yea np, but if it's really bugfix then 3.0.x is fine.

@sergeyklay sergeyklay merged commit 0aaf059 into phalcon:3.0.x Jan 12, 2017
@sergeyklay
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants