-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aliases for ciphers in Phalcon\Crypt #12539
Conversation
The older version of Phalcon used aliases for cipher and now they are not available. They are easy to use and migration will be easier if they persist.
Update changelog too. Also we don't accept PRs to master branch. Please send it to 3.0.x. |
|
I see that on 3.0.x are only fixes. If I have to I can change it to 3.1.x. |
Well you wrote this is bug fix, so it's for 3.0.x, not sure which exactly bug it's fixing. |
When I migrated my application to Phalcon 3.0.x it gave me an exception. These changes fixed the issue. I've decided to try and contribute it directly and not to create an issue in the system for someone else to solve. |
Yea np, but if it's really bugfix then 3.0.x is fine. |
Thanks |
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
The old versions supported aliases of ciphers and now it doesn't. They are easier to use and migration will be easier for those who use this class.
Thanks