Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Phalcon crashes when NuSphere debugger is enabled - *solution included* #2414

Closed
temuri416 opened this issue May 9, 2014 · 5 comments

Comments

@temuri416
Copy link
Contributor

@phalcon @niden

Guys, after testing various commits I've found a problem code that is the root cause of the following issues:
#2356 #2118 #2104

The following two lines should be removed:

https://github.com/phalcon/cphalcon/blob/master/ext/session/adapter.c#L399
https://github.com/phalcon/cphalcon/blob/master/ext/session/adapter.c#L410

It was a part of commit ID 3aecf06 and caused all of my problems with debugging Phalcon-based application.

I've tested it several times - latest 1.3.2 without those two lines is rock-solid.

Thanks!!


Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@niden
Copy link
Member

niden commented May 13, 2014

Thanks @temuri416

From what I see in the commits the variable is used to detect whether DBG has been installed here:

nusphere_dbg_present = (zend_get_extension("DBG") != NULL);

I haven't used nusphere before so I cannot comment on that, but doesn't DBG report that it is installed? If so the if statement seems legit.

@temuri416
Copy link
Contributor Author

@niden

That variable correctly reflects presence of DBG. All other checks work as they should. It's just those two lines that mess it all up.

Can they be removed?

Thanks!

@niden
Copy link
Member

niden commented May 20, 2014

@temuri416 #2454

@niden
Copy link
Member

niden commented May 20, 2014

@temuri416 Please run this through your system and let us know if that one resolved it.

@temuri416
Copy link
Contributor Author

Awesome, thanks! I'll test it ASAP.

@phalcon phalcon closed this as completed Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants