Phalcon\Forms\Element\Select::addOption(array $option)

[alvinkohcm]

Class: Phalcon\Forms\Element\Select

Version: : Phalcon 1.2.6
Issue: Method addOption() does not correctly render argument type Array as select option.

addOption(array $option)

$selection = new Phalcon\Forms\Element\Select("selection");
$selection->addOption(array('id'=>'1','value'=>'Apple')); //Does not work
$selection->addOption(array('2'=>'Orange')); //Does not work
$selection->addOption('Test String'); //Works with String
echo $selection->render(array('multiple'=>'yes'));

$selection2 = new Phalcon\Forms\Element\Select("selection2"); 
$selection2->setOptions(array('1'=>'Apple','2'=>'Orange','3'=>'Test String'));
echo $selection2->render(array('multiple'=>'yes'));

Output:

<select multiple="yes" name="selection" id="selection">
    <option value="0">Array</option>
    <option value="1">Array</option>
    <option value="2">Test String</option>
</select>

<select multiple="yes" name="selection2" id="selection2">
    <option value="1">Apple</option>
    <option value="2">Orange</option>
    <option value="3">Test String</option>
</select>

[ghost]

Fixed, could you please check?

[alvinkohcm]

Much thanks @sjinks for responding to this issue.
Checked (v1.3.0) and result does not seem to be ideal:

<select id="selection" name="selection" multiple="yes" size="10">
   <optgroup label="0">
      <option value="id">1</option>
      <option value="value">Apple</option>
   </optgroup>
   <optgroup label="1">
      <option value="2">Orange</option>
   </optgroup>
   <option value="2">Test String</option>
</select>

• $option added via addOption() is contained in another array resulting in the <option>(s) being encased in <optgroup> group tags
• From a user perspective, array('value'=>'label') seems to be the expected format required e.g. array('2'=>'Orange') as a HTML <option> always contains a value and a corresponding display label.

$selection = new \Phalcon\Forms\Element\Select("selection");
$selection->addOption(array('id'=>'1','value'=>'Apple'));
$selection->addOption(array('2'=>'Orange'));
$selection->addOption('Test String');

echo $selection->render(array('multiple'=>'yes','size'=>10)); // render Select element

Output from: print_r($selection->getOptions());

Array
(
    [0] => Array
        (
            [id] => 1
            [value] => Apple
        )
    [1] => Array
        (
            [2] => Orange
        )
    [2] => Test String
)

[ghost]

Please run

php build/gen-build.php

then rebuild Phalcon and try again — build/ version is not updated automatically from ext/

[alvinkohcm]

<select id="selection" name="selection" multiple="yes" size="10">
    <option selected="selected" value="0">Test String</option>
    <option value="2">Orange</option>
    <option value="l">1</option>
    <option value="value">Apple</option>
</select>

Works after building from ext/
Thank you!

[ehsanmr]

i have same issue with optgroup
should i edit ext/tag/select.c file and recompile or there is a better solution?