Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: build failure with PHP 8.2 using bundled libpcre2 #16295

Closed
remicollet opened this issue Feb 28, 2023 · 1 comment · Fixed by #16296
Closed

[BUG]: build failure with PHP 8.2 using bundled libpcre2 #16295

remicollet opened this issue Feb 28, 2023 · 1 comment · Fixed by #16296
Assignees
@Jeckerson
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High

Comments

@remicollet
Copy link
Contributor

remicollet commented Feb 28, 2023 •
edited
Loading

Trying to build on RHEL / CentOS 7

/builddir/build/BUILD/php-phalcon5-5.2.0/NTS/phalcon.zep.c:8054:2: error: unknown type name 'pcre_cache_entry'
 8054 |  pcre_cache_entry *pce;
      |  ^~~~~~~~~~~~~~~~
/builddir/build/BUILD/php-phalcon5-5.2.0/NTS/phalcon.zep.c:8069:13: warning: implicit declaration of function 'pcre_get_compiled_regex_cache' [-Wimplicit-function-declaration]
 8069 |  if ((pce = pcre_get_compiled_regex_cache(Z_STR_P(regex))) == NULL) {
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This only affects PHP 8.2 / pcre2 10.40 (build OK with PHP 7.4 / pcre2 10.32, PHP 8.0 / pcre2 10.35, PHP 8.1 / pcre2 10.39)
This does not affect builds using system libpcre2 (tested on RHEL 8 / pcre2 10.32, RHEL 9 / pcre2 10.40, Fedora 38 / pcre2 10.42)
@remicollet remicollet added bug A bug report status: unverified Unverified labels Feb 28, 2023
@remicollet remicollet changed the title [BUG]: build failure with old pcre2 version 10.23 [BUG]: build failure with PHP using bundled libpcre Feb 28, 2023
@remicollet remicollet mentioned this issue Feb 28, 2023
Closed
@Jeckerson Jeckerson linked a pull request Feb 28, 2023 that will close this issue
#16293 - Add ext/pcre/php_pcre.h header for PHP8.2 #16296
Merged
5 tasks
@Jeckerson Jeckerson self-assigned this Feb 28, 2023
@Jeckerson Jeckerson added 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Feb 28, 2023
@remicollet remicollet changed the title [BUG]: build failure with PHP using bundled libpcre [BUG]: build failure with PHP 8.2 using bundled libpcre2 Feb 28, 2023
@niden niden added the status: high High label Feb 28, 2023
@niden niden added this to Phalcon v5 Feb 28, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Phalcon v5 Feb 28, 2023
@niden niden moved this from Backlog to In Progress in Phalcon v5 Feb 28, 2023
@niden
Copy link
Member

niden commented Feb 28, 2023

Resolved in #16296

Thank you @remicollet

@niden niden closed this as completed Feb 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Implemented in Phalcon v5 Feb 28, 2023
@niden niden moved this from Implemented to Released in Phalcon v5 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
Phalcon v5
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#16293 - Add ext/pcre/php_pcre.h header for PHP8.2 phalcon/cphalcon
3 participants
@remicollet @niden @Jeckerson