Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phalcon\Mvc\Micro finish handler need typeof test #16240

Closed
yannux opened this issue Dec 8, 2022 · 1 comment · Fixed by #16241
Closed

Phalcon\Mvc\Micro finish handler need typeof test #16240

yannux opened this issue Dec 8, 2022 · 1 comment · Fixed by #16241
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@yannux
Copy link

yannux commented Dec 8, 2022

Phalcon version 5.1.2
Minor bug

Message

Phalcon\Mvc\Micro::handle(): instanceof expects an object instance

When checking finish handler there is no typof test

cphalcon/phalcon/Mvc/Micro.zep

Line 681 in bf9b70c

if finish instanceof MiddlewareInterface {

But for other handler like after there is a typeof === "object"
https://github.com/phalcon/cphalcon/blob/v5.1.2/phalcon/Mvc/Micro.zep#L615

It's seem the fix was missing with this commit 30379b6#diff-f935028249fa6ba82f53d50fcb058af22c3cec8db674d7b875292bd9b573669d
@niden niden self-assigned this Dec 8, 2022
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Dec 8, 2022
@niden niden added this to Phalcon v5 Dec 8, 2022
@niden niden moved this to Backlog in Phalcon v5 Dec 8, 2022
@niden niden mentioned this issue Dec 8, 2022
Merged
5 tasks
@niden niden linked a pull request Dec 8, 2022 that will close this issue
T16240 micro finish #16241
Merged
5 tasks
@niden
Copy link
Member

niden commented Dec 8, 2022

Resolved in #16241

Thank you @yannux

@niden niden closed this as completed Dec 8, 2022
Repository owner moved this from Backlog to Implemented in Phalcon v5 Dec 8, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T16240 micro finish
2 participants
@yannux @niden